[U-Boot] [PATCH v2 19/21] net: cosmetic: Alphabetize includes in net.c

Simon Glass sjg at chromium.org
Fri Apr 27 08:25:08 CEST 2012


Hi Joe,

On Wed, Mar 28, 2012 at 12:42 PM, Joe Hershberger <joe.hershberger at ni.com>wrote:

> Signed-off-by: Joe Hershberger <joe.hershberger at ni.com>
> Cc: Joe Hershberger <joe.hershberger at gmail.com>
> Cc: Simon Glass <sjg at chromium.org>
> Cc: Mike Frysinger <vapier at gentoo.org>
> ---
> Changes for v2:
>   - Split from "Improve variable names and code readability"
>
>  net/net.c |   20 ++++++++++----------
>  1 files changed, 10 insertions(+), 10 deletions(-)
>
> diff --git a/net/net.c b/net/net.c
> index 4736ba1..0371e2e 100644
> --- a/net/net.c
> +++ b/net/net.c
> @@ -75,27 +75,27 @@
>
>
>  #include <common.h>
> -#include <watchdog.h>
>  #include <command.h>
>  #include <linux/compiler.h>
>

put this just above "arp.h" I think




>  #include <net.h>
> -#include "arp.h"
> -#include "bootp.h"
> -#include "tftp.h"
> -#include "rarp.h"
> -#include "nfs.h"
> -#ifdef CONFIG_STATUS_LED
> +#if defined(CONFIG_STATUS_LED)
>  #include <status_led.h>
>  #include <miiphy.h>
>

Swap those?


>  #endif
> -#if defined(CONFIG_CMD_SNTP)
> -#include "sntp.h"
> -#endif
> +#include <watchdog.h>
> +#include "arp.h"
> +#include "bootp.h"
>  #include "cdp.h"
>  #if defined(CONFIG_CMD_DNS)
>  #include "dns.h"
>  #endif
> +#include "nfs.h"
>  #include "ping.h"
> +#include "rarp.h"
> +#if defined(CONFIG_CMD_SNTP)
> +#include "sntp.h"
> +#endif
> +#include "tftp.h"
>
>  DECLARE_GLOBAL_DATA_PTR;
>
> --
> 1.6.0.2
>
>
Regards,
Simon


More information about the U-Boot mailing list