[U-Boot] [PATCH v2 1/2] CONFIG_SYS_BAUDRATE_TABLE: Add <config_fallbacks.h>, place there

Tom Rini trini at ti.com
Fri Apr 27 21:02:08 CEST 2012


On 04/27/2012 11:40 AM, Wolfgang Denk wrote:
> Dear Tom Rini,
>
> In message<4F9ADF70.4080009 at ti.com>  you wrote:
>>
>>> Technically, I don't like the name "config_fallbacks.h"; how about
>>> "config_defaults.h" instead?
>>
>> We have config_defaults.h today, which comes before<configs/...h>
>
> Yes, why not use it for this purpose as well?  It seems the
> appropriate place to me.

Order of operations.  We would have to move it to after <configs/...h> 
(and change behavior, and break a few board files, git grep 
CONFIG_BOOTM_ include/) or make everyone not using the standard undef to 
get their table, which I started down (as you could see from the patch) 
but it's quite invasive.  Or we add a fallbacks file and have config.h be:
First: default commands <config_cmd_default.h>
Second: Global defaults <config_defaults.h>
Third: board <configs/...h>
Fourth: arch fallbacks <asm/config.h>
Fifth: Global fallbacks

Since developers should be tweaking just their board config file I'm 
calling what's before defaults and what's after fallbacks..

-- 
Tom


More information about the U-Boot mailing list