[U-Boot] [PATCH v2 03/11] cfb_console: Fix function console_back

Marek Vasut marex at denx.de
Sun Apr 29 00:15:58 CEST 2012


Dear Pali Rohár,

>  * Do not disable and enable cursor again

Can you elaborate please?

> 
> Signed-off-by: Pali Rohár <pali.rohar at gmail.com>
> ---
>  drivers/video/cfb_console.c |    2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/video/cfb_console.c b/drivers/video/cfb_console.c
> index 904caf7..51ea167 100644
> --- a/drivers/video/cfb_console.c
> +++ b/drivers/video/cfb_console.c
> @@ -721,7 +721,6 @@ static void console_scrollup(void)
> 
>  static void console_back(void)
>  {
> -	CURSOR_OFF;
>  	console_col--;
> 
>  	if (console_col < 0) {
> @@ -730,7 +729,6 @@ static void console_back(void)
>  		if (console_row < 0)
>  			console_row = 0;
>  	}
> -	CURSOR_SET;
>  }
> 
>  static void console_newline(void)

Best regards,
Marek Vasut


More information about the U-Boot mailing list