[U-Boot] [PATCH v2 06/11] cfb_console: Add support for some ANSI terminal escape codes
Pali Rohár
pali.rohar at gmail.com
Sun Apr 29 09:29:29 CEST 2012
On Sunday 29 April 2012 00:19:03 Marek Vasut wrote:
> > +
> > + if (ansi_buf_size > 0) {
> > + /*
> > + 0 - ESC
> > + 1 - [
> > + 2 - num1
> > + 3 - ..
> > + 4 - ;
> > + 5 - num2
> > + 6 - ..
> > + 7 - cchar
>
> wrong comment ... did you even run these patches through
> checkpatch? Run them and resubmit please, I'm ending my review
> here.
>
Yes, I all patches except first is OK for checkpatch. It show no
errors and no warnings.
--
Pali Rohár
pali.rohar at gmail.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20120429/b81516de/attachment.pgp>
More information about the U-Boot
mailing list