[U-Boot] [PATCH V3] i.MX6: mx6q_sabrelite: add SATA bindings
Eric Nelson
eric.nelson at boundarydevices.com
Mon Apr 30 15:33:01 CEST 2012
Hi Marek,
On 04/29/2012 07:27 PM, Marek Vasut wrote:
> Dear Eric Nelson,
>
>> Signed-off-by: Eric Nelson<eric.nelson at boundarydevices.com>
>>
>> ---
>> V2 has been stripped of the board-independent changes and
>> uses clrsetbits_le32() instead of twiddling bits by hand.
>>
>> <snip>
>>
>> +int setup_sata(void)
>> +{
>> + struct iomuxc_base_regs *const iomuxc_regs
>> + = (struct iomuxc_base_regs *) IOMUXC_BASE_ADDR;
>> + int rval = enable_sata_clock();
>> + if (rval)
>> + return rval ;
>
> Can you keep the return<val>; consistent with the rest of the file? (so avoid
> return<val>[space];) ... I dunno if this violates some coding style document
> though. Just a nitpick.
>
Can do. I'll update this in V4.
More information about the U-Boot
mailing list