[U-Boot] [PATCH 2/2 v7] Add support for MINI2440 (s3c2440).

Marek Vasut marex at denx.de
Mon Apr 30 15:49:54 CEST 2012


Dear Gabriel Huau,

> On Mon, Apr 30, 2012 at 03:21:49PM +0200, Marek Vasut wrote:
> > Dear Gabriel Huau,
> > 
> > > +
> > > +/*
> > > + * Miscellaneous configurable options
> > > + */
> > > +#define	CONFIG_LONGHELP
> > > +#define	CONFIG_SYS_PROMPT	"MINI2440 => "
> > > +#define	CONFIG_SYS_CBSIZE	256
> > > +#define	CONFIG_SYS_PBSIZE
> > 
> > (CONFIG_SYS_CBSIZE+sizeof(CONFIG_SYS_PROMPT)+16)
> > 
> > > +#define	CONFIG_SYS_MAXARGS	32
> > > +#define CONFIG_SYS_BARGSIZE	CONFIG_SYS_CBSIZE
> > 
> > #define[tab] mixed with #define[space] ... also, please Cc Albert Aribaud
> > for the next round, he'll likely pick this up.
> 
> You gonna to kill me ... :P. checkpatch.pl didn't see this obfuscation
> ;).

Fix checkpatch or report it ... this might be a worthy addition.

Best regards,
Marek Vasut


More information about the U-Boot mailing list