[U-Boot] [PATCH V2 03/13] ARM: bcm2835: add Raspberry Pi model B board

[Tom Rini]

On Tue, Jul 31, 2012 at 10:13:33PM -0600, Stephen Warren wrote:
> The Raspberry Pi model B uses the BCM2835 SoC, has 256MB of RAM, contains
> an SMSC 9512 USB LAN/Hub chip, and various IO connectors. For more details,
> see http://www.raspberrypi.org/.
> 
> Signed-off-by: Stephen Warren <swarren at wwwdotorg.org>
[snip]
> +int dram_init(void)
> +{
> +	gd->ram_size = SZ_256M;
> +
> +	return 0;
> +}

You should use get_ram_size(CONFIG_SYS_SDRAM_BASE,
max-possible-dram-size);  I say this as I just found a "oh, so that's
why mainline reports the right amount of memory and other tree does not"
bug yesterday.  This should also be in the SoC-generic code area (like
say arch/arm/cpu/arm1176/bcm2835/board.c).  Sorry I didn't spot this
last go-round.

[snip]
> +#define CONFIG_SYS_BAUDRATE_TABLE	{ 9600, 19200, 38400, 57600, 115200 }

This is the table now in <config_fallbacks.h> which is auto-included.

> +#define CONFIG_SYS_PROMPT_HUSH_PS2	"> "

This is now the default prompt value, so you can drop this line.

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20120801/9a5a71e1/attachment.pgp>