[U-Boot] [PATCH 5/7 V3] SPI: Add SPI Driver for EXYNOS.

Mike Frysinger vapier at gentoo.org
Wed Aug 1 18:32:00 CEST 2012


On Wednesday 01 August 2012 05:33:30 Rajeshwari Shinde wrote:
> --- /dev/null
> +++ b/drivers/spi/exynos_spi.c
>
> +DECLARE_GLOBAL_DATA_PTR;

i don't think you use this, so delete

> +void spi_flush_fifo(struct spi_slave *slave)

static

> +void spi_init(void)
> +{
> ...
> +	for (i = 0; i < EXYNOS5_SPI_NUM_CONTROLLERS; i++) {
> ...
> +		bus_count++;

why bother with a static bus_count ?  just use the existing define.
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20120801/66f0cd59/attachment.pgp>


More information about the U-Boot mailing list