[U-Boot] [PATCH] net: Improve the speed of netconsole

[Joe Hershberger]

Hi Mike,

On Wed, Aug 1, 2012 at 11:35 AM, Mike Frysinger <vapier at gentoo.org> wrote:
> On Monday 30 July 2012 17:08:41 Joe Hershberger wrote:
>> On Wed, Jul 25, 2012 at 1:49 PM, Mike Frysinger wrote:
>> > On Tuesday 24 July 2012 16:11:15 Joe Hershberger wrote:
>> >> --- a/net/eth.c
>> >> +++ b/net/eth.c
>> >>
>> >> +#ifdef CONFIG_NETCONSOLE_PERSIST_ETH
>> >> +int eth_init_state_only(bd_t *bis)
>> >> +{
>> >> +     eth_current->state = ETH_STATE_ACTIVE;
>> >> +
>> >> +     return 0;
>> >> +}
>> >> +
>> >> +void eth_halt_state_only(void)
>> >> +{
>> >> +     eth_current->state = ETH_STATE_PASSIVE;
>> >> +}
>> >> +#endif
>> >
>> > these *really* should be static inlines in the global header.  they're so
>> > dirt simple, the overhead of the function call is probably much higher
>> > than the single memory store.
>>
>> I can do that, but I don't think it will save anything.  Since
>> eth_current is static, I would have to change it to eth_get_dev(), and
>> we're back to a function call.  Thoughts?
>
> i wonder why eth_get_dev is an external func then :)

An attempt at encapsulation I assume.  I guess I could just make it global.

-Joe