[U-Boot] [PATCH 0/5] light updates of common pci code; some pci ids

[Wolfgang Denk]

Dear Andrew Sharp,

In message <1343860040-30941-1-git-send-email-andywyse6 at gmail.com> you wrote:
> [PATCH 1/5] pci: fix errant data types and corresponding access functions
> [PATCH 2/5] [cosmetic] pci: clean up some whitespace and formatting
> [PATCH 3/5] pci: minor cleanup of CONFIG_PCI_PNP usage
> [PATCH 4/5] pci: update pci_ids.h with a few new entries
> [PATCH 5/5] pci: add CONFIG_PCI_ENUM_ONLY for platforms that don't need PCI setup done

Please run your patches through checkpatch and fix the errors /
warnings:

ERROR: trailing statements should be on next line
#147: FILE: drivers/pci/pci.c:206:
+			for (bdf = PCI_BDF(bus, 0, 0);
[...]
+				bdf < PCI_BDF(bus+1,0,0);

ERROR: space required after that ',' (ctx:VxV)
#154: FILE: drivers/pci/pci.c:211:
+				bdf < PCI_BDF(bus+1,0,0);
 				                   ^

ERROR: space required after that ',' (ctx:VxV)
#154: FILE: drivers/pci/pci.c:211:
+				bdf < PCI_BDF(bus+1,0,0);
 				                     ^

ERROR: space required after that ',' (ctx:VxV)
#162: FILE: drivers/pci/pci.c:213:
+				bdf += PCI_BDF(0,0,1)) {
 				                ^

ERROR: space required after that ',' (ctx:VxV)
#162: FILE: drivers/pci/pci.c:213:
+				bdf += PCI_BDF(0,0,1)) {
 				                  ^

WARNING: line over 80 characters
#165: FILE: drivers/pci/pci.c:216:
+					pci_read_config_byte(bdf, PCI_HEADER_TYPE, &header_type);

WARNING: line over 80 characters
#183: FILE: drivers/pci/pci.c:223:
+				pci_read_config_word(bdf, PCI_VENDOR_ID, &vendor);

WARNING: line over 80 characters
#184: FILE: drivers/pci/pci.c:224:
+				pci_read_config_word(bdf, PCI_DEVICE_ID, &device);

WARNING: line over 80 characters
#187: FILE: drivers/pci/pci.c:227:
+					if (vendor == ids[i].vendor && device == ids[i].device) {

WARNING: line over 80 characters
#286: FILE: drivers/pci/pci.c:392:
+	debug("PCI Config: I/O=0x%lx, Memory=0x%llx, Command=0x%lx\n", io, (u64)mem,

WARNING: line over 80 characters
#306: FILE: drivers/pci/pci.c:419:
+				pci_hose_write_config_dword(hose, dev, bar + 4, 0xffffffff);

WARNING: line over 80 characters
#323: FILE: drivers/pci/pci.c:444:
+			pci_hose_write_config_dword(hose, dev, bar, (u32)(bar_value >> 32));

WARNING: line over 80 characters
#391: FILE: drivers/pci/pci.c:634:
+	     dev <  PCI_BDF(bus, PCI_MAX_PCI_DEVICES - 1, PCI_MAX_PCI_FUNCTIONS -1);

ERROR: need consistent spacing around '-' (ctx:WxV)
#391: FILE: drivers/pci/pci.c:634:
+	     dev <  PCI_BDF(bus, PCI_MAX_PCI_DEVICES - 1, PCI_MAX_PCI_FUNCTIONS -1);
 	                                                                        ^

ERROR: "foo* bar" should be "foo *bar"
#424: FILE: drivers/pci/pci_auto.c:53:
+int pciauto_region_allocate(struct pci_region* res, pci_size_t size,

WARNING: line over 80 characters
#434: FILE: drivers/pci/pci_auto.c:103:
+	for (bar = PCI_BASE_ADDRESS_0; bar < PCI_BASE_ADDRESS_0 + (bars_num * 4); bar += 4) {

WARNING: line over 80 characters
#470: FILE: drivers/pci/pci_auto.c:269:
+					((pci_io->bus_lower - 1) & 0x0000f000) >> 8);

WARNING: line over 80 characters
#473: FILE: drivers/pci/pci_auto.c:271:
+					((pci_io->bus_lower - 1) & 0xffff0000) >> 16);

WARNING: line over 80 characters
#488: FILE: drivers/pci/pci_auto.c:288:
+			if (!hose->pci_io || hose->pci_io->size < hose->regions[i].size)

WARNING: line over 80 characters
#494: FILE: drivers/pci/pci_auto.c:292:
+			if (!hose->pci_mem || hose->pci_mem->size < hose->regions[i].size)

WARNING: line over 80 characters
#522: FILE: drivers/pci/pci_auto.c:363:
+		pciauto_setup_device(hose, dev, 2, hose->pci_mem, hose->pci_prefetch,

WARNING: line over 80 characters
#532: FILE: drivers/pci/pci_auto.c:390:
+		pciauto_setup_device(hose, dev, 6, hose->pci_mem, hose->pci_prefetch,

WARNING: line over 80 characters
#543: FILE: drivers/pci/pci_auto.c:399:
+		pciauto_setup_device(hose, dev, 0, hose->pci_mem, hose->pci_prefetch,

WARNING: line over 80 characters
#557: FILE: drivers/pci/pci_auto.c:410:
+		DEBUGF("PCI Autoconfig: Skipping bridge device %d\n", PCI_DEV(dev));

WARNING: line over 80 characters
#566: FILE: drivers/pci/pci_auto.c:422:
+		pciauto_setup_device(hose, dev, 0, hose->pci_mem, hose->pci_prefetch,

WARNING: line over 80 characters
#572: FILE: drivers/pci/pci_auto.c:427:
+		pciauto_setup_device(hose, dev, 6, hose->pci_mem, hose->pci_prefetch,

total: 7 errors, 19 warnings, 427 lines checked



WARNING: please, no space before tabs
#124: FILE: include/pci_ids.h:386:
+#define PCI_DEVICE_ID_ATI_SBX00_SATA_AHCI ^I0x4391$

WARNING: please, no space before tabs
#125: FILE: include/pci_ids.h:387:
+#define PCI_DEVICE_ID_ATI_SBX00_EHCI ^I0x4396$

WARNING: please, no space before tabs
#126: FILE: include/pci_ids.h:388:
+#define PCI_DEVICE_ID_ATI_SBX00_OHCI ^I0x4397$


Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
"There is nothing new under the sun, but there are lots of old things
we don't know yet."                                  - Ambrose Bierce