[U-Boot] [PATCH] tegra20: add back USE_PRIVATE_LIBGCC

Wolfgang Denk wd at denx.de
Tue Aug 7 20:36:43 CEST 2012


Dear Lucas Stach,

In message <1344298788-7059-1-git-send-email-dev at lynxeye.de> you wrote:
> As discussed here [http://patchwork.ozlabs.org/patch/158202/] we want to
> use USE_PRIVATE_LIBGCC still.
> 
> However commit 5286f1ce dropped it regardless. Adding this back fixes a
> hang while handing over from SPL to U-Boot on Colibri T20.
> 
> Signed-off-by: Lucas Stach <dev at lynxeye.de>
> CC: Stephen Warren <swarren at wwwdotorg.org>
> CC: Tom Warren <TWarren at nvidia.com>
> ---
>  arch/arm/cpu/armv7/tegra20/config.mk | 2 ++
>  1 Datei geändert, 2 Zeilen hinzugefügt(+)
> 
> diff --git a/arch/arm/cpu/armv7/tegra20/config.mk b/arch/arm/cpu/armv7/tegra20/config.mk
> index 6432e75..e666f6b 100644
> --- a/arch/arm/cpu/armv7/tegra20/config.mk
> +++ b/arch/arm/cpu/armv7/tegra20/config.mk
> @@ -23,4 +23,6 @@
>  # Foundation, Inc., 59 Temple Place, Suite 330, Boston,
>  # MA 02111-1307 USA
>  #
> +USE_PRIVATE_LIBGCC = yes

NAK.

USE_PRIVATE_LIBGCC is a workaround for broken tool chains only.  It
must never be automatically set for any configuration.

If you know of tool chains that require this, then complain there and
have the bugs fixed with hteir upstream.

Yes, I know this may be painful to you, and it _shall_ be painful, so
that you finally take some action to have the tool chains fixed that
need so.

I will not accept anything like this in mainline.  Sorry.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Status quo. Latin for "the mess we're in."


More information about the U-Boot mailing list