[U-Boot] [PATCH] ext2fs: fix warning: 'blocknxt' may be used uninitialized with gcc 4.2

Wolfgang Denk wd at denx.de
Tue Aug 7 20:55:41 CEST 2012


Dear Tom Rini,

In message <1344358714-14032-1-git-send-email-trini at ti.com> you wrote:
> The above warning was introduced originally in 436da3c "ext2load:
> increase read speed" and fixed for newer toolchains in b803273 "ext2fs:
> fix warning: 'blocknxt' may be used uninitialized".  This change did not
> fix the warning with gcc 4.2, as found in ELDK 4.2.
> 
> If we rework the while loop to initalize blocknxt before entering the
> warning really goes away.  Tested on am335x with an approx 7mb file and
> crc32 in U-Boot befor and after this change.
> 
> Cc: Wolfgang Denk <wd at denx.de>
> Cc: Eric Nelson <eric.nelson at boundarydevices.com>
> Cc: Thierry Reding <thierry.reding at avionic-design.de>
> Cc: Jason Cooper <u-boot at lakedaemon.net>
> Cc: Andreas Bießmann <andreas.devel at googlemail.com>
> Cc: Reinhard Arlt <reinhard.arlt at esd-electronics.com>
> Cc: Kim Phillips <kim.phillips at freescale.com>
> Signed-off-by: Tom Rini <trini at ti.com>
> ---
>  fs/ext2/ext2fs.c |    4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

Applied, thanks.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
I know engineers. They love to change things.             - Dr. McCoy


More information about the U-Boot mailing list