[U-Boot] [PATCH 2/2] powerpc/mpc85xx/p1_p2_rdb: add all LAWs during SPL

McClintock Matthew-B29882 B29882 at freescale.com
Thu Aug 9 04:28:50 CEST 2012


On Wed, Aug 8, 2012 at 9:27 PM, Matthew McClintock <msm at freescale.com> wrote:
> On Wed, Aug 8, 2012 at 8:06 PM, Scott Wood <scottwood at freescale.com> wrote:
>> LAW init is skipped in the SPL payload because it's assumed that the SPL
>> has taken care of it -- so make sure the SPL loads all the LAWs as is
>> done on other boards.
>
> It might be good to try this on a few different compilers to see if
> they are all under the size requirement. I've made this smaller from
> other work so it could still be OK.

Err, I spoke too soon... this might not be upstreamed though.

-M

>
> -M
>
>>
>> This bug was introduced by:
>>
>>   commit 4589728e214958a4e6e011a081a68d360c49d7a5
>>   Author: Kumar Gala <galak at kernel.crashing.org>
>>   Date:   Fri Nov 11 08:14:53 2011 -0600
>>
>>     powerpc/85xx: Fix builds of P1020/P2020RDB-PC_36BIT_NAND
>>
>>     Size grew a bit so nand-spl didn't fit in 4k, reduce done by removing
>>     LAW entries not needed during SPL phase.
>>
>> Signed-off-by: Scott Wood <scottwood at freescale.com>
>> ---
>>  board/freescale/p1_p2_rdb_pc/law.c |    2 --
>>  1 file changed, 2 deletions(-)
>>
>> diff --git a/board/freescale/p1_p2_rdb_pc/law.c b/board/freescale/p1_p2_rdb_pc/law.c
>> index 7968919..0da8300 100644
>> --- a/board/freescale/p1_p2_rdb_pc/law.c
>> +++ b/board/freescale/p1_p2_rdb_pc/law.c
>> @@ -25,13 +25,11 @@
>>  #include <asm/mmu.h>
>>
>>  struct law_entry law_table[] = {
>> -#ifndef CONFIG_NAND_SPL
>>         SET_LAW(CONFIG_SYS_CPLD_BASE_PHYS, LAW_SIZE_1M, LAW_TRGT_IF_LBC),
>>         SET_LAW(CONFIG_SYS_PMC_BASE_PHYS, LAW_SIZE_64K, LAW_TRGT_IF_LBC),
>>  #ifdef CONFIG_VSC7385_ENET
>>         SET_LAW(CONFIG_SYS_VSC7385_BASE_PHYS, LAW_SIZE_1M, LAW_TRGT_IF_LBC),
>>  #endif
>> -#endif
>>         SET_LAW(CONFIG_SYS_FLASH_BASE_PHYS, LAW_SIZE_64M, LAW_TRGT_IF_LBC),
>>  #ifdef CONFIG_SYS_NAND_BASE_PHYS
>>         SET_LAW(CONFIG_SYS_NAND_BASE_PHYS, LAW_SIZE_1M, LAW_TRGT_IF_LBC),
>> --
>> 1.7.9.5
>>
>> _______________________________________________
>> U-Boot mailing list
>> U-Boot at lists.denx.de
>> http://lists.denx.de/mailman/listinfo/u-boot


More information about the U-Boot mailing list