[U-Boot] [PATCH v2 3/5] sh: Add support pin function control using GPIO

[Wolfgang Denk]

Dear Nobuhiro Iwamatsu,

In message <1341471662-1157-3-git-send-email-nobuhiro.iwamatsu.yj at renesas.com> you wrote:
> Renesas SH and R-Mobile set up device using PFC.
> This provide the framework. Most codes were brought from linux kernel.
...
> +static void config_reg_helper(struct pinmux_info *gpioc,
> +			      struct pinmux_cfg_reg *crp,
> +			      unsigned long in_pos,
> +#if 0
> +			      void __iomem **mapped_regp,
> +#else
> +			      void **mapped_regp,
> +#endif

Please clean up and remove the dead code here.  Thanks.


> +#if 0
> +static DEFINE_SPINLOCK(gpio_lock);
> +static struct pinmux_info *chip_to_pinmux(struct gpio_chip *chip)
> +{
> +	return container_of(chip, struct pinmux_info, chip);
> +}
> +#endif

Ditto here.


Also, checkpatch complains - WARNING: do not add new typedefs

Please check this, too.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
When it is incorrect, it is, at least *authoritatively* incorrect.
                                    - Hitchiker's Guide To The Galaxy