[U-Boot] [PATCH 1/8] EXT2: Indent cleanup of dev.c

Wolfgang Denk wd at denx.de
Thu Aug 9 22:01:48 CEST 2012


Dear Marek Vasut,

In message <1339176713-13309-2-git-send-email-marex at denx.de> you wrote:
> Signed-off-by: Marek Vasut <marex at denx.de>
> Cc: Wolfgang Denk <wd at denx.de>
> ---
>  fs/ext2/dev.c |   74 +++++++++++++++++++++++++++------------------------------
>  1 file changed, 35 insertions(+), 39 deletions(-)
> 
> diff --git a/fs/ext2/dev.c b/fs/ext2/dev.c
> index 315ff53..f8cb8b7 100644
> --- a/fs/ext2/dev.c
> +++ b/fs/ext2/dev.c
> @@ -35,6 +35,7 @@ static disk_partition_t part_info;
>  int ext2fs_set_blk_dev(block_dev_desc_t *rbdd, int part)
>  {
>  	ext2fs_block_dev_desc = rbdd;
> +	int ret;
>  
>  	if (part == 0) {
>  		/* disk doesn't use partition table */
> @@ -42,60 +43,53 @@ int ext2fs_set_blk_dev(block_dev_desc_t *rbdd, int part)
>  		part_info.size = rbdd->lba;
>  		part_info.blksz = rbdd->blksz;
>  	} else {
> -		if (get_partition_info
> -		    (ext2fs_block_dev_desc, part, &part_info)) {
> +		ret = get_partition_info(ext2fs_block_dev_desc, part,
> +						&part_info);
> +		if (ret)

Actually this is definitely more than just an "indent" cleanup.  Please
fix the Subject:.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
It is not best to swap horses while crossing the river.
- Abraham Lincoln


More information about the U-Boot mailing list