[U-Boot] [PATCH] powerpc:Fix return type & parameter passed for I/O functions
Wolfgang Denk
wd at denx.de
Thu Aug 9 22:24:15 CEST 2012
Dear Prabhakar Kushwaha,
In message <1334134139-421-1-git-send-email-prabhakar at freescale.com> you wrote:
> Return type of in_8, in_be16 and in_le16 should not be'int'. Update it to type
> u8/u16/u32.
> Although 'unsigned' for in_be32 and in_le32 is correct. But to make return type
> uniform across the file changed to u32
>
> Similarly, parameter passed to out_8, out_be16, out_le16 ,out_be32 & out_le32
> should not be 'int'.Change it to type u8/u16/u32.
>
> Signed-off-by: Prabhakar Kushwaha <prabhakar at freescale.com>
> ---
> Based upon git://git.denx.de/u-boot.git branch master
>
> arch/powerpc/include/asm/io.h | 30 +++++++++++++++---------------
> 1 files changed, 15 insertions(+), 15 deletions(-)
Applied, thanks.
Maybe we should even more synchronize this file against current Linux
versions? Like changing "extern inline" into "static inline", etc. ?
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Far back in the mists of ancient time, in the great and glorious days
of the former Galactic Empire, life was wild, rich and largely tax
free. - Douglas Adams, _The Hitchhiker's Guide to the Galaxy_
More information about the U-Boot
mailing list