[U-Boot] [PATCH] spl: remove forced linking of commands into SPL

Tyler Olmstead tyler.j.olmstead at gmail.com
Fri Aug 10 02:42:52 CEST 2012


Thanks Tom. I've been looking at this some too, and while the commands
are removed from the build I've been playing with (hawkboard), they
seem to not be removed completely from omap3_beagle. This is confusing
as both use -ffunction-sections, -fdata-sections, and --gc-sections. I
noticed the hawkboard has it's own linker script for SPL builds, and
I'm wondering if this doesn't account for the difference.
spl/u-boot-spl.lds uses wild cards for data where u-boot-spl-hawk.lds
explicitly names the data sections to link. I'm far from an expert on
linker scripts, so I can't test this theory without fear of messing up
something.

-- Tyler

On Thu, Aug 9, 2012 at 4:00 PM, Tom Rini <trini at ti.com> wrote:
> On Wed, Aug 08, 2012 at 07:24:13PM -0700, Tyler Olmstead wrote:
>
>> Remove linker command line options from the SPL makefile
>> that force the inclusion of unreferenced command code from
>> linked object files. As commands are not used in the SPL,
>> these options resulted in an unnecessary increase in the
>> image size, in addition to introducing the possibility of
>> tricky link errors in the case where the command code
>> contained symbols that were not resolved by linking in the
>> limited objects compiled in the SPL build.
>>
>> Signed-off-by: Tyler Olmstead <tyler.j.olmstead at gmail.com>
>
> OK, I've done some more poking at the specific problem I found and,
> well, we're doing everything right and I don't have a solution, but I
> think this patch moves us forward.  Based on what I'm seeing so far,
> new U_BOOT_CMDs would be removed correctly, including strings.  Or be
> fixed when I fix the current problem.
>
> Acked-by: Tom Rini <trini at ti.com>
>
> --
> Tom


More information about the U-Boot mailing list