[U-Boot] [PATCH 2/2] powerpc/mpc85xx/p1_p2_rdb: add all LAWs during SPL

Huang Changming-R66093 r66093 at freescale.com
Fri Aug 10 08:54:28 CEST 2012


This maybe cause the overlap error:
powerpc-linux-gnu-ld: section .resetvec loaded at [00000000ff800ffc,00000000ff800fff] overlaps section .data loaded at [00000000ff800ec8,00000000ff80102f]

maybe we can think about to remove or modify Kumar's patch:

commit 7639675131673e8f1582d760203a9af34fba9e79
Author: Kumar Gala <galak at kernel.crashing.org>
Date:   Thu Feb 3 09:02:13 2011 -0600

    powerpc/8xxx: Fix LAW init to respect pre-initialized entries

    If some pre-boot or earlier stage bootloader (NAND SPL) has setup LAW
    entries consider them good and mark them used.

    In the NAND SPL case we skip re-initializing based on the law_table
    since the SPL phase already did that.

    Signed-off-by: Kumar Gala <galak at kernel.crashing.org>


Best Regards
Jerry Huang


> -----Original Message-----
> From: u-boot-bounces at lists.denx.de [mailto:u-boot-bounces at lists.denx.de]
> On Behalf Of Scott Wood
> Sent: Friday, August 10, 2012 12:52 AM
> To: McClintock Matthew-B29882
> Cc: Wood Scott-B07421; Kumar Gala; u-boot at lists.denx.de
> Subject: Re: [U-Boot] [PATCH 2/2] powerpc/mpc85xx/p1_p2_rdb: add all LAWs
> during SPL
> 
> On 08/08/2012 09:28 PM, McClintock Matthew-B29882 wrote:
> > On Wed, Aug 8, 2012 at 9:27 PM, Matthew McClintock <msm at freescale.com>
> wrote:
> >> On Wed, Aug 8, 2012 at 8:06 PM, Scott Wood <scottwood at freescale.com>
> wrote:
> >>> LAW init is skipped in the SPL payload because it's assumed that the
> >>> SPL has taken care of it -- so make sure the SPL loads all the LAWs
> >>> as is done on other boards.
> >>
> >> It might be good to try this on a few different compilers to see if
> >> they are all under the size requirement. I've made this smaller from
> >> other work so it could still be OK.
> 
> I don't have "a few different compilers" handy to test with -- and even
> if I did, it wouldn't be exhaustive.  This fixes a bug.  If someone finds
> that they can't build with some other compiler, they can report the bug
> and we'll deal with it.
> 
> > Err, I spoke too soon... this might not be upstreamed though.
> 
> Why not?
> 
> -Scott
> 
> 
> _______________________________________________
> U-Boot mailing list
> U-Boot at lists.denx.de
> http://lists.denx.de/mailman/listinfo/u-boot




More information about the U-Boot mailing list