[U-Boot] [PATCH 3/3] COMMON: Use __stringify() instead of MK_STR()

Marek Vasut marex at denx.de
Fri Aug 10 23:20:22 CEST 2012


Dear Anatolij Gustschin,

> Hi Marek,
> 
> On Wed,  8 Aug 2012 12:52:19 +0200
> Marek Vasut <marex at denx.de> wrote:
> ...
> 
> > diff --git a/common/env_common.c b/common/env_common.c
> > index d9e990d..39e1792 100644
> > --- a/common/env_common.c
> > +++ b/common/env_common.c
> > @@ -37,8 +37,6 @@ DECLARE_GLOBAL_DATA_PTR;
> > 
> >  /***********************************************************************
> >  *
> >  
> >   * Default settings to be used when no valid environment is found
> >   */
> > 
> > -#define XMK_STR(x)	#x
> > -#define MK_STR(x)	XMK_STR(x)
> 
> including linux/stringify.h here is needed. It doesn't build
> otherwise, since this file doesn't include common.h:
> ...
> Configuring for actux1_4_16 - Board: actux1, Options: FLASH2X2
> /home/ag/git/u-boot/common/env_embedded.c:110:15: error: expected ‘}’
> before ‘__stringify’ make[1]: *** [env_embedded.o] Error 1
> make: *** [tools] Error 2
> arm-linux-gnueabi-size: './u-boot': No such file
> /home/ag/git/u-boot/common/env_embedded.c:110:15: error: expected ‘}’
> before ‘__stringify’ make[1]: *** [env_embedded.o] Error 1
> make[1]: *** Waiting for unfinished jobs....
> make[1]: *** wait: No child processes.  Stop.
> make: *** [tools] Error 2

Will do a full rebuild again. Sorry for the crap.

> Please fix. Thanks!
> 
> Anatolij

Best regards,
Marek Vasut


More information about the U-Boot mailing list