[U-Boot] [PATCH 5/5] Add env var giving the board revision

[Mike Frysinger]

On Friday 10 August 2012 13:46:08 Benoît Thébaudeau wrote:
> The board revision can be a useful env var, like its serial number.

unless i missed something, there is no standard "rev" variable today, which 
means this change can easily break anyone who happens to already be using a 
variable named "rev".

i also don't see value here in hardcoding another variable that:
	- no one is setting
	- is way too generic (rev of *what* ?  cpu ?  board ?  u-boot ?  
something else ?)
	- adds nothing on top of the existing "serial#"

so NAK from me
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20120811/60097306/attachment.pgp>