[U-Boot] [PATCH 1/1] USB: Fix strict aliasing in ohci-hcd

Marek Vasut marex at denx.de
Sun Aug 12 02:07:30 CEST 2012


Dear Troy Kisky,

> commit 5f6aa03fda2a0a79940765865c1e4266be8a75f8
>     USB: Fix complaints about strict aliasing in OHCI-HCD
> 
> tried to fix this, but gcc4.4 still complains. So, this
> patch basically reverts the above and does a simpler fix.
> 
> also, the above commit incorrectly changed
> 	/* corresponds to data_buf[4-7] */
> 	datab [1] = 0;
> to
> 
> 	/* corresponds to databuf.u8[4-7] */
> 	databuf.u8[1] = 0;
> 
> This patch also fixes that.
[...]

AGAIN?! :-C

If I were to run git log on that file, I'd get like five such "fixes" :-(

I'll review this properly tomorrow, this will be certainly a very pleasant 
reviewing time ;-)

Best regards,
Marek Vasut


More information about the U-Boot mailing list