[U-Boot] arm: omap: Fix switching back to nandecc sw.

Igor Grinberg grinberg at compulab.co.il
Sun Aug 12 10:12:37 CEST 2012


Hi Jeroen,

Thanks for the patch!

On 08/10/12 23:06, Jeroen Hofstee wrote:
> Switching back to nandecc sw fails to write correctly. A fix for this is
> already mentioned in the thread below, lets fix it.
> 
> mentioned in http://lists.denx.de/pipermail/u-boot/2012-February/119002.html

I would expect to have an actual explanation in the commit message
instead of (or along with) the link above and not just something like:
we fix nandecc sw, want to know more, go somewhere else...

> 
> Signed-off-by: Jeroen Hofstee <jhofstee at victronenergy.com>

After the commit message is fixed,

Acked-by: Igor Grinberg <grinberg at compulab.co.il>

> ---
>  drivers/mtd/nand/omap_gpmc.c |    1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/mtd/nand/omap_gpmc.c b/drivers/mtd/nand/omap_gpmc.c
> index ca868ef..71aec1a 100644
> --- a/drivers/mtd/nand/omap_gpmc.c
> +++ b/drivers/mtd/nand/omap_gpmc.c
> @@ -280,6 +280,7 @@ void omap_nand_switch_ecc(int32_t hardware)
>          omap_hwecc_init(nand);
>          printf("HW ECC selected\n");
>      } else {
> +        nand->ecc.size = 0;
>          nand->ecc.mode = NAND_ECC_SOFT;
>          /* Use mtd default settings */
>          nand->ecc.layout = NULL;

-- 
Regards,
Igor.


More information about the U-Boot mailing list