[U-Boot] [PATCH 5/5] Add env var giving the board revision

[Benoît Thébaudeau]

Dear Wolfgang Denk,

> > OK. Actually, the only reason for which I need this patch is to
> > make a variable
> > read-only, and the only reason for which you reject it is because
> > you fear that
> > it breaks something.
> >
> > So we could add a config like CONFIG_BOARD_REV_RO_VARIABLE to
> > enable the code in
> > my patch. But I think you won't like that either because you will
> > find it too
> > specific.
> 
> No, this may solve your problem, but will never scale for any real
> life use.

OK.

> > What about adding a config like CONFIG_READONLY_VARS that would be
> > an array
> > initializer containing the names of the board-specific variables to
> > make
> > read-only? _do_env_set() and fw_env_write() would use it besides
> > the hard-coded
> > serial# and the like. That would give something like:
> > #define CONFIG_READONLY_VARS {"my_ro_var1", "my_ro_var2",
> > "board_rev"}
> > That would be a very simple solution to make everyone happy before
> > Wolfgang
> > implements a more sophisticated solution with read-only and
> > volatile flags. What
> > do you think?
> 
> Please feel free to add this to your local code.

By "local", do you mean that this new suggestion would still not be generic
enough for you to be interested in it for a patch?

Best regards,
Benoît