[U-Boot] [PATCH 6/6] nand_spl: change out_be32 to raw_writel and depend on subsequent sync

Scott Wood scottwood at freescale.com
Tue Aug 14 01:34:42 CEST 2012


On 08/13/2012 06:31 PM, McClintock Matthew-B29882 wrote:
> On Mon, Aug 13, 2012 at 6:23 PM, Scott Wood <scottwood at freescale.com> wrote:
>> On 08/13/2012 01:10 PM, Matthew McClintock wrote:
>>> This change reduces the SPL size by removing the redundant syncs produced
>>> by out_be32 and just replies on one final sync
>>>
>>> Done with:
>>>
>>> sed -r '/in_be32/b; s/(out_be32)\(([^,]*),\s+(.*)\)/__raw_writel(\3, \2)/g' -i `git grep --name-only sdram_init nand_spl/`
>>>
>>> Signed-off-by: Matthew McClintock <msm at freescale.com>
>>> ---
>>>  nand_spl/board/freescale/p1010rdb/nand_boot.c     |   54 ++++++++++-----------
>>>  nand_spl/board/freescale/p1023rds/nand_boot.c     |   42 ++++++++--------
>>>  nand_spl/board/freescale/p1_p2_rdb_pc/nand_boot.c |   48 +++++++++---------
>>>  3 files changed, 71 insertions(+), 73 deletions(-)
>>
>> This should come first if the other patches break without it, to
>> preserve bisectability.
> 
> I think they all work on at least some compilers.... not that that's
> extremely helpful.

Was this patch meant to free up room for the other patches, or was it
just bundled in because it's touching the same code?

-Scott




More information about the U-Boot mailing list