[U-Boot] [PATCH] mtest: Disable dcache during test

Albert ARIBAUD albert.u.boot at aribaud.net
Tue Aug 14 08:27:10 CEST 2012


Hi Mike,

On Sat, 11 Aug 2012 16:15:16 -0400, Mike Frysinger <vapier at gentoo.org>
wrote:
> On Saturday 11 August 2012 16:05:36 Benoît Thébaudeau wrote:
> > On 08/11/2012 21:47, Andrew Dyer wrote:
> > > I agree with Mike, use the current dcache settings. U-boot has
> > > always assumed the user knew what they were doing.
> > > If you want to print a small message with the dcache setting that
> > > makes sense to me, but no big warning.
> > 
> > Then, something like the following at runtime in the first lines
> > printed my mtest?
> > 
> > dcache state: on
> 
> i'd be fine with that.  something like below (if you want to test &
> post, that'd be good).
> -mike

I'd disagree with this solution; one can easily overlook casual test
messages like these. To me it is better that the person doing mtest not
trust the cache state at all and check / set it.

Amicalement,
-- 
Albert.


More information about the U-Boot mailing list