[U-Boot] [PATCH v2] arm: omap: Fix switching back to nandecc sw.

Jeroen Hofstee dasuboot at myspectrum.nl
Tue Aug 14 22:39:29 CEST 2012


Orjan Friberg wrote at [1]:

"For the beagleboard, ecc.size is not explicitly set when doing 'nandecc
sw'. If it's not set for the NAND_ECC_SOFT case in nand_scan_tail, it's
set to 256 bytes.

When doing 'nandecc hw', ecc.size is set to 512 bytes. Hence, when
changing back to 'nandecc sw' ecc.size remains at 512 bytes and suddenly
the format has changed."

No patch has been submitted and the issue was still present. This patch
adds the mentioned solution. Tested on a tam3517 board.

[1] http://lists.denx.de/pipermail/u-boot/2012-February/119002.html

cc: Orjan Friberg <of at flatfrog.com>
Acked-by: Igor Grinberg <grinberg at compulab.co.il>
Acked-by: Nikita Kiryanov <nikita at compulab.co.il>
Signed-off-by: Jeroen Hofstee <jhofstee at victronenergy.com>
---
  drivers/mtd/nand/omap_gpmc.c |    1 +
  1 file changed, 1 insertion(+)

diff --git a/drivers/mtd/nand/omap_gpmc.c b/drivers/mtd/nand/omap_gpmc.c
index ca868ef..f1469d1 100644
--- a/drivers/mtd/nand/omap_gpmc.c
+++ b/drivers/mtd/nand/omap_gpmc.c
@@ -283,6 +283,7 @@ void omap_nand_switch_ecc(int32_t hardware)
          nand->ecc.mode = NAND_ECC_SOFT;
          /* Use mtd default settings */
          nand->ecc.layout = NULL;
+        nand->ecc.size = 0;
          printf("SW ECC selected\n");
      }

-- 
1.7.9.5



More information about the U-Boot mailing list