[U-Boot] [PATCH v2 3/3] Makefile: cosmetic: optimize usage of LIBS-y

[Kumar Gala]

On Aug 14, 2012, at 8:52 AM, Kumar Gala wrote:

> 
> On Aug 10, 2012, at 4:17 PM, Wolfgang Denk wrote:
> 
>> Dear daniel.schwierzeck at gmail.com,
>> 
>> In message <1342741198-9105-1-git-send-email-daniel.schwierzeck at gmail.com> you wrote:
>>> From: Daniel Schwierzeck <daniel.schwierzeck at gmail.com>
>>> 
>>> Signed-off-by: Daniel Schwierzeck <daniel.schwierzeck at gmail.com>
>>> 
>>> ---
>>> Changes for v2:
>>> - optimized HAVE_VENDOR_COMMON_LIB macro as suggested by Mike
>>> - optimized HAVE_VENDOR_COMMON_LIB macro also in spl/Makefile
>>> ---
>>> Makefile     | 17 ++++++-----------
>>> spl/Makefile |  3 +--
>>> 2 files changed, 7 insertions(+), 13 deletions(-)
>> 
>> Applied, thanks.
>> 
>> Best regards,
>> 
>> Wolfgang Denk
> 
> I spoke too soon, this patch is causing build issues on P4080DS_config:
> 
> [galak at right u-boot]$ make -j40 -s
> arch/powerpc/cpu/mpc85xx/libmpc85xx.o: In function `ft_cpu_setup':
> /local/home/galak/git/u-boot/arch/powerpc/cpu/mpc85xx/fdt.c:614: undefined reference to `get_board_sys_clk'
> arch/powerpc/cpu/mpc85xx/libmpc85xx.o: In function `get_sys_info':
> /local/home/galak/git/u-boot/arch/powerpc/cpu/mpc85xx/speed.c:77: undefined reference to `get_board_sys_clk'
> arch/powerpc/cpu/mpc85xx/libmpc85xx.o:(.got2+0x344): undefined reference to `tlb_table'
> arch/powerpc/cpu/mpc85xx/libmpc85xx.o:(.got2+0x348): undefined reference to `num_tlb_entries'
> arch/powerpc/lib/libpowerpc.o: In function `board_init_r':
> /local/home/galak/git/u-boot/arch/powerpc/lib/board.c:850: undefined reference to `mac_read_from_eeprom'
> common/libcommon.o:(.u_boot_cmd+0x370): undefined reference to `do_mac'
> drivers/misc/libmisc.o:(.got2+0x14): undefined reference to `law_table'
> drivers/misc/libmisc.o:(.got2+0x18): undefined reference to `num_law_entries'
> drivers/pci/libpci.o: In function `pci_init':
> /local/home/galak/git/u-boot/drivers/pci/pci.c:731: undefined reference to `pci_init_board'
> board/freescale/corenet_ds/libcorenet_ds.o: In function `ft_board_setup':
> /local/home/galak/git/u-boot/board/freescale/corenet_ds/corenet_ds.c:231: undefined reference to `pci_of_setup'
> board/freescale/corenet_ds/libcorenet_ds.o: In function `board_ft_fman_fixup_port':
> /local/home/galak/git/u-boot/board/freescale/corenet_ds/eth_p4080.c:230: undefined reference to `fdt_set_phy_handle'
> /local/home/galak/git/u-boot/board/freescale/corenet_ds/eth_p4080.c:238: undefined reference to `fdt_set_phy_handle'
> make: *** [u-boot] Error 1
> [galak at right u-boot]$ 
> 
> - k

This is fixed by:

http://patchwork.ozlabs.org/patch/177235/

- k