[U-Boot] [PATCH 0/3] at91: atmel_nand: add PMECC(Programmable Multibit ECC controller) support

[Andreas Bießmann]

Dear Josh Wu,

On 15.08.2012 10:19, Josh Wu wrote:
> Hi, Andreas
> 
> Thank you for the quick reply.
> 
> On 8/15/2012 3:50 PM, Andreas Bießmann wrote:
>> Dear Josh Wu,
>>
>> On 15.08.2012 08:50, Josh Wu wrote:
>>> Hi, Andreas

<snip>

>> And the last, you should add at least one user of this feature. Isn't
>> the lately applied at91sam9x5ek (is in u-boot-atmel/master and
>> u-boot-arm/master) a perfect user for that?
> 
> you are right, The PMECC usage is for 9x5ek board.
> I planed to push the PMECC support patches in 9x5 board in two part:
>    one is this series, which only include nand flash driver changes. I
> thought those patches should be merged by u-boot mtd maintainer.

I don't care whether Scott Wood or I take the patch (Scott, can you
please comment?). If Scott takes it I should ack or the other way round.

>    Another part is some patches for 9x5 board file and config file which
> enable PMECC in 9x5ek board. Those patches are not sent out yet.

For me it is a must to have at least one user of the added feature.

> Now I think if you can merge all above patches to u-boot mainline, then
> maybe I can sent those patches together. What do you think about this?

I think there should be one patch in the series enabling the usage of
the feature. Who takes this patch is another question but I favor to
enable the series in a single step.

>>> On 8/9/2012 6:21 PM, Josh Wu wrote:
>>>> This patch series will add PMECC support for atmel nand driver in
>>>> u-boot.
>>>>
>>>> The driver patch is ported from kernel patch. The main different from
>>>> kernel patch is
>>>> the modification about registers access part. in this version it via a
>>>> register structure to access.
>> A question regarding linux driver. You say it is derived from the kernel
>> driver, but I can not see PMECC stuff in kernel:
> 
> Sorry,  I am not make it clear about this. Actually, The PMECC stuff is
> not in v3.6-rc1 now, it is queued in kernel MTD maintainer's git tree:
> http://git.infradead.org/linux-mtd.git/commit/1c7b874d33b463f7150b1ab4617f000af9b327fd

Ah, I see, just found your mail on the mtd list a couple of minutes ago.
I asked just to have something to compare with, I do not want to dive
into the specs just to get a clue whats going on.

> Seems the maintainer missed the merge window of v3.6-rc1. I am not sure
> that can go into v3.6 or not. But I think it is not a bad idea to push
> those code into u-boot. :)

Me too.

<snip>

>>>> It is tested in atmel 9x5 series board.
>> Unfortunately I can not test this driver cause I do only have older
>> sam926x devices around.
> 
> If I send 9x5 board enable patches with nand PMECC patches together, I
> think maybe other people can test it in 9x5ed board.

Would be great to get some tested by for the patches.

Best regards

Andreas Bießmann