[U-Boot] [PATCH 2/7 V4] SPI: Add W25Q32 to Winbond SPI flash table

Joonyoung Shim dofmind at gmail.com
Fri Aug 17 10:28:02 CEST 2012


Hi Rajeshwari.

2012/8/2 Rajeshwari Shinde <rajeshwari.s at samsung.com>:
> SMDK EVT1  has a different Winbond part, added its part details
> to the SPI flash table
>
> Signed-off-by: Abhilash Kesavan <a.kesavan at samsung.com>
> Signed-off-by: Rajeshwari Shinde <rajeshwari.s at samsung.com>
> ---
> Changes in V2:
>         - Corrected the commit message.
> Changes in V3:
>         - None.
> Changes in V4:
>         - Rebased on Mainline u-boot.git.
>  drivers/mtd/spi/winbond.c |    8 ++++++++
>  1 files changed, 8 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/mtd/spi/winbond.c b/drivers/mtd/spi/winbond.c
> index 427b71f..ae4e48a 100644
> --- a/drivers/mtd/spi/winbond.c
> +++ b/drivers/mtd/spi/winbond.c
> @@ -62,6 +62,14 @@ static const struct winbond_spi_flash_params winbond_spi_flash_table[] = {
>                 .nr_blocks              = 256,
>                 .name                   = "W25Q128",
>         },
> +       {
> +               .id                     = 0x5014,
> +               .l2_page_size           = 8,
> +               .pages_per_sector       = 16,
> +               .sectors_per_block      = 16,

Above three fields is removed from commit
a4ed3b653163367628d4ad173dfe3faf388da0ac,
but in spi_flash_probe_winbond()

       flash->page_size = 4096;

original codes are

       /* Assuming power-of-two page size initially. */
       page_size = 1 << params->l2_page_size;
...
       flash->page_size = page_size;


so i think flash->page_size is 256 or (1 << 8).

When flash->page_size is 4096, is your spi_flash device working well?


> +               .nr_blocks              = 128,
> +               .name                   = "W25Q80",
> +       },
>  };
>
>  struct spi_flash *spi_flash_probe_winbond(struct spi_slave *spi, u8 *idcode)
> --
> 1.7.4.4
>
> _______________________________________________
> U-Boot mailing list
> U-Boot at lists.denx.de
> http://lists.denx.de/mailman/listinfo/u-boot

Thanks.

-- 
- Joonyoung Shim


More information about the U-Boot mailing list