[U-Boot] [PATCH 1/9] SOUND: Add I2S driver

[Andrew Dyer]

The code in the i2s.c file is still full of samsung soc specific stuff, so
I think the filename is misleading.  Something like samsung-i2s.c would be
more appropriate.
On Aug 17, 2012 1:44 AM, "Rajeshwari Birje" <rajeshwari.birje at gmail.com>
wrote:

> Hi Andrew,
>
> Thank you for comments.
>
> On Thu, Aug 16, 2012 at 8:29 PM, Andrew Dyer <amdyer at gmail.com> wrote:
> > I don't have any comment on the body of the patch, but calling this an
> i2s
> > patch is misleading.  I2s is a generic standard for moving stereo audio
> > around, and many chips support it.
> >
> > This patch looks like i2s support for a specific codec chip and the
> > filenames should reflect that.
> >
> In this patch we can support different codecs without doing any
> changes to i2s files.
> The only change would be in sound.c, where you have to check for
> specific codec required and set values accordingly.
> We use I2S1 here, but it is not specific to any particular codec.
> > _______________________________________________
> > U-Boot mailing list
> > U-Boot at lists.denx.de
> > http://lists.denx.de/mailman/listinfo/u-boot
> >
> Regards,
> Rajeshwari Shinde.
>