[U-Boot] [PATCH] hwconfig: Move HWCONFIG_BUFFER_SIZE into hwconfig.h

[York Sun]

On Fri, 2012-08-17 at 12:54 -0500, Kumar Gala wrote:
> On Aug 15, 2012, at 7:53 PM, York Sun wrote:
> 
> > Before proper environment is setup, we extract hwconfig and put it into a
> > buffer with size HWCONFIG_BUFFER_SIZE. We need to enlarge the buffer to
> > accommodate longer string. Since this macro is used in multiple files, we
> > move it into hwconfig.h.
> > 
> > Signed-off-by: York Sun <yorksun at freescale.com>
> > ---
> > 
> > arch/powerpc/cpu/mpc85xx/cpu_init.c           |    2 --
> > arch/powerpc/cpu/mpc85xx/fsl_corenet_serdes.c |    2 --
> > arch/powerpc/cpu/mpc8xxx/ddr/options.c        |    1 -
> > include/hwconfig.h                            |    2 ++
> > 4 files changed, 2 insertions(+), 5 deletions(-)
> 
> 1. I don't think HWCONFIG_BUFFER_SIZE should be getting set in include/hwconfig.h, this is unique to FSL 8xxx usage not to hwconfig

If no one else uses this feature, I can move it to
arch/powerpc/include/asm/config.h. How about that?

> 2. if you are doing to something like this it should be:
> 
> 	#ifndef CONFIG_HWCONFIG_BUFFER_SIZE
> 	  #define CONFIG_HWCONFIG_BUFFER_SIZE 128
> 	#endif
> 
> This allowing a board port to set it as needed.
> 

This is a good idea. Will do.

York