[U-Boot] [PATCH] mx5: add iomux-mx51.h include

Benoît Thébaudeau benoit.thebaudeau at advansee.com
Fri Aug 17 21:35:05 CEST 2012


Dear Matt Sealey,

> On Fri, Aug 17, 2012 at 1:42 PM, Benoît Thébaudeau
> <benoit.thebaudeau at advansee.com> wrote:
> > Dear Matt Sealey,
> >
> > These pad settings are broken. All the pins of each peripheral
> > should not always
> > have the same pad settings. E.g., UART input pins should have their
> > pull-up
> > enabled in order to avoid spurious character input if these pins
> > are left
> > floating from time to time. The same applies to eCSPI.
> 
> I'm not going to comment on the quality of the pad settings, but
> since
> MX51 arrived in any kernel these have been the pad settings for *all*
> MX51, MX53, MX6 boards and in the case of MX6 are applied in U-Boot
> right now for example on mx6qsabrelite if not the others too. These
> settings are in device trees now, too.
> 
> If you want to "correct" years of reliable operation in U-Boot, go
> ahead, and fix Linux while you're at it. I'm just porting the status
> quo.

I'm just saying that from experience. I've already seen issues related to that
kind of things.

Best regards,
Benoît


More information about the U-Boot mailing list