[U-Boot] [PATCH 1/2] mx5: Add default pin initializers

Matt Sealey matt at genesi-usa.com
Fri Aug 17 22:38:37 CEST 2012


On Fri, Aug 17, 2012 at 3:25 PM, Stefano Babic <sbabic at denx.de> wrote:
> On 14/08/2012 17:46, Benoît Thébaudeau wrote:
>> Create default pin initialization functions for the default iomux function
>> assignments of the main peripherals.
>>
>> Signed-off-by: Benoît Thébaudeau <benoit.thebaudeau at advansee.com>
>> Cc: Stefano Babic <sbabic at denx.de>
>> ---
>
> I think that setting each pin with mxc_request_iomux() is not a great
> idea. Maybe another solution would be to provide a table with the pinmux
> for the whole SOC and a funtion to set all of them, as
> imx_iomux_v3_setup_multiple_pads. This is also similar to the current
> implementation in u-boot for other SOCs, for example TI.

Done and submitted for MX51 - and Efika MX is ported and through QA.
Can you review?

Benoit has some valid suggestions for changes, which can come later,
but for now moving to that for MX51 boards should be a net zero
difference for all implemented boards. I don't have space on my desk
to fire up my MX53 Quickstart or EVK to test those, but porting the
files for MX53 from Linux should not be a big deal and further
combining the 3 implementations differences (moving GPIO_NUMBER to
imx-common/iomux-v3.h instead of it being SoC-specific for example) is
something that would better be done once everything's in and working.

-- 
Matt Sealey <matt at genesi-usa.com>
Product Development Analyst, Genesi USA, Inc.


More information about the U-Boot mailing list