[U-Boot] [[Patch V2] mips: 00/16] add mips64 support to U-Boot

Daniel Schwierzeck daniel.schwierzeck at gmail.com
Sun Aug 19 15:00:33 CEST 2012


Hi,

2012/8/17 Zhizhou Zhang <etou.zh at gmail.com>:
>
> This patch add mips64 support.
> ---
> Change log for V2:
>   - move mips64 build flags to cpu/mips64.mk
>   - add cache size probe
>   - remove cache.S

please add changelogs to the patches which you have changed since the
previous submission

>
> Zhizhou Zhang (16):
>   add mips64 standalone support

please add the prefix "MIPS:" to all commit messages. That is what
I actually meant in the other mail. Then you can simply do a
git format-patches --subject-prefix "PATCH vN" ...

>   add cpu/mips64/Makefile
>   add cpu/mips64/config.mk
>   add cpu/mips64/cpu.c
>   add cpu/mips64/interrupts.c
>   add cpu/mips64/start.S
>   add cpu/mips64/time.c

I think those patches could be squashed to a single patch with a
commit message like:

MIPS: add support for MIPS64 CPUs

>   Let UNCACHED_SDRAM be available to mips64
>   add cache description struct
>   modify io operation for mips64
>   Make size_t equaled to unsigned long
>   modify u-boot.lds for mips64
>   add board define in boards.cfg
>   add mips64 standalone link script
>   add configs/qemu-mips64.h
>   modify qemu-mips/config.mk

please use more descriptive commit messages for your changes.
It should be clear what you have changed and why.

>
>  arch/mips/config.mk                 |    4 +
>  arch/mips/cpu/mips64/Makefile       |   47 +++++
>  arch/mips/cpu/mips64/config.mk      |   39 ++++
>  arch/mips/cpu/mips64/cpu.c          |  133 +++++++++++++
>  arch/mips/cpu/mips64/interrupts.c   |   39 ++++
>  arch/mips/cpu/mips64/start.S        |  373 +++++++++++++++++++++++++++++++++++
>  arch/mips/cpu/mips64/time.c         |   86 ++++++++
>  arch/mips/include/asm/addrspace.h   |    2 +-
>  arch/mips/include/asm/cache.h       |   11 ++
>  arch/mips/include/asm/io.h          |   18 +-
>  arch/mips/include/asm/posix_types.h |   12 +-
>  board/qemu-mips/config.mk           |    3 +-
>  board/qemu-mips/u-boot.lds          |    8 +
>  boards.cfg                          |    1 +
>  examples/standalone/mips64.lds      |   59 ++++++
>  include/configs/qemu-mips64.h       |  171 ++++++++++++++++
>  16 files changed, 1000 insertions(+), 6 deletions(-)
>  create mode 100644 arch/mips/cpu/mips64/Makefile
>  create mode 100644 arch/mips/cpu/mips64/config.mk
>  create mode 100644 arch/mips/cpu/mips64/cpu.c
>  create mode 100644 arch/mips/cpu/mips64/interrupts.c
>  create mode 100644 arch/mips/cpu/mips64/start.S
>  create mode 100644 arch/mips/cpu/mips64/time.c
>  create mode 100644 examples/standalone/mips64.lds
>  create mode 100644 include/configs/qemu-mips64.h
>
> --
> 1.7.9.5
>

-- 
Best regards,
Daniel


More information about the U-Boot mailing list