[U-Boot] [PATCH 07/10] mx5 clocks: Fix get_uart_clk()

Stefano Babic sbabic at denx.de
Mon Aug 20 12:05:12 CEST 2012


On 20/08/2012 11:52, Stefano Babic wrote:
> Why should we pass a parameter to this function ? Can it be used in
> another context ? I do not think so, because it decodes the value in the
> cscmr1 register.
> 
> I think it is better if you move the reading of the cscmr1 register
> inside this function and you drop the unneeded parameter.

Never mind - I had not yet read the next patch. Discharge this comment.

Best regards,
Stefano


-- 
=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================


More information about the U-Boot mailing list