[U-Boot] [PATCH] ARM: lacie_kw: add support for WIRELESS_SPACE

Prafulla Wadaskar prafulla at marvell.com
Tue Aug 21 09:16:40 CEST 2012



> -----Original Message-----
> From: u-boot-bounces at lists.denx.de [mailto:u-boot-
> bounces at lists.denx.de] On Behalf Of Albert ARIBAUD
> Sent: 18 August 2012 02:59
> To: Tom Rini
> Cc: u-boot at lists.denx.de
> Subject: Re: [U-Boot] [PATCH] ARM: lacie_kw: add support for
> WIRELESS_SPACE
> 
> Hi Tom,
> 
> On Fri, 17 Aug 2012 10:55:38 -0700, Tom Rini <trini at ti.com> wrote:
> 
> > On Thu, Aug 16, 2012 at 08:08:34PM +0200, Albert ARIBAUD wrote:
> >
> > > Signed-off-by: Albert ARIBAUD <albert.u.boot at aribaud.net>
> > [snip]
> > > @@ -90,8 +100,14 @@
> > >  #define CONFIG_SYS_IDE_MAXDEVICE        1
> > >  #if defined(CONFIG_NET2BIG_V2)
> > >  #define CONFIG_SYS_PROMPT		"2big2> "
> > > -#else
> > > +#elif defined(CONFIG_NETSPACE_V2)
> > >  #define CONFIG_SYS_PROMPT		"ns2> "
> > > +#elif defined(CONFIG_INETSPACE_V2)
> > > +#define CONFIG_SYS_PROMPT		"is2> "
> > > +#elif defined(CONFIG_WIRELESS_SPACE)
> > > +#define CONFIG_SYS_PROMPT		"ws> "
> > > +#else
> > > +#define CONFIG_SYS_PROMPT		"lacie-kw> "
> >
> > Is this really a good thing?  Over here I've been trying / hoping to
> > get everyone to just use 'U-Boot # ' as the prompt as this makes
> > automated testing easier and there's other run-time ways to see what
> > we're on.

I personally vote to have common boot prompt 'U-boot #'.

> 
> I quite like prompts that identify the board I'm on, but it's not a
> must either. Cc:ing Simon in cas his own patches re lacie_kw would be
> impacted by your suggestion.

Well, we can expose a command to detect/print the board info, if needed.

Regards...
Prafulla . . .


More information about the U-Boot mailing list