[U-Boot] [Patch v3 2/2] net: asix: add support for AX88772B

[Mike Frysinger]

On Tuesday 21 August 2012 09:23:13 Lucas Stach wrote:
> +	struct ueth_data *dev = (struct ueth_data *)eth->priv;
> +	struct asix_private *priv = (struct asix_private *)dev->dev_priv;

not that it's harmful, but priv is void*, so the casts aren't needed

> +	ALLOC_CACHE_ALIGN_BUFFER(unsigned char, ee_buf, 2);
> +	ALLOC_CACHE_ALIGN_BUFFER(unsigned char, buf, ETH_ALEN);

since you don't use both buffers at the same time, just declare one that is big 
enough to work for either code path.  so looks like you could throw away 
ee_buf here.
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20120821/90f535e4/attachment.pgp>