[U-Boot] [PATCH 2/2] pxa25x: Add USB ethernet gadget

[Marek Vasut]

Dear Łukasz Dałek,

> Signed-off-by: Łukasz Dałek <luk0104 at gmail.com>
> ---
>  drivers/usb/gadget/Makefile     |    1 +
>  drivers/usb/gadget/pxa25x_udc.c | 2059
> +++++++++++++++++++++++++++++++++++++++ drivers/usb/gadget/pxa25x_udc.h | 
> 168 ++++
>  3 files changed, 2228 insertions(+), 0 deletions(-)
>  create mode 100644 drivers/usb/gadget/pxa25x_udc.c
>  create mode 100644 drivers/usb/gadget/pxa25x_udc.h

[...]

Quick glance seems mostly OK.

> -*/ +
> +#ifdef DEBUG
> +# ifdef DEBUG_NOISY
> +#  define NOISY 1
> +# else
> +#  define NOISY 0
> +# endif
> +#else
> +# define NOISY 0
> +#endif

So ... define DEBUG_NOISY always and set it to some value ... then you won't 
need this additional NOISY at all.

> +#endif /* __LINUX_USB_GADGET_PXA25X_H */

Best regards,
Marek Vasut