[U-Boot] [[Patch V2] mips: 01/16] add mips64 standalone support

[Mike Frysinger]

On Saturday 18 August 2012 22:25:24 Zhi-zhou Zhang wrote:
> On 8/18/12, Mike Frysinger <vapier at gentoo.org> wrote:
> > On Saturday 18 August 2012 08:22:51 Zhi-zhou Zhang wrote:
> >> On Sat, Aug 18, 2012 at 3:31 AM, Mike Frysinger wrote:
> >> > On Friday 17 August 2012 11:30:44 Zhizhou Zhang wrote:
> >> > > --- a/arch/mips/config.mk
> >> > > +++ b/arch/mips/config.mk
> >> > > 
> >> > > +ifeq "$(CPU)" "mips64"
> >> > > +CONFIG_STANDALONE_LOAD_ADDR ?= 0xFfffFfff80200000 -T mips64.lds
> >> > > +else
> >> > >  CONFIG_STANDALONE_LOAD_ADDR ?= 0x80200000 -T mips.lds
> >> > > +endif
> >> > 
> >> > the cpu config.mk is sourced after this one.  you could change this
> >> > to: CONFIG_STANDALONE_LOAD_ADDR ?=
> >> > $(DEFAULT_MIPS_STANDALONE_LOAD_ADDR)
> >> > DEFAULT_MIPS_STANDALONE_LOAD_ADDR = 0x80200000 -T mips.lds
> >> > 
> >> > then in the mips64/config.mk:
> >> > DEFAULT_MIPS_STANDALONE_LOAD_ADDR = 0xFfffFfff80200000 -T mips64.lds
> >> 
> >> Thanks for you advising. But if I changed like so, I should modify
> >> mips32/
> >> config.mk and xburst/config.mk as also.
> > 
> > why ?  my suggestion shouldn't affect any other cpu config.mk.
> 
> Oh, I'm so sorry, I think that you mean to replace
> CONFIG_STANDALONE_LOAD_ADDR by DEFAULT_MIPS_STANDALONE_LOAD_ADDR.
> So your idea is to keep both CONFIG_STANDALONE_LOAD_ADDR and
> DEFAULT_MIPS_STANDALONE_LOAD_ADDR, one for mips64, anther for mips32.
> Actually I haven't test standalone example. I add standalone config
> and build option for I would get an error if didn't do that. It brings
> me a lot of mess. I want to disable stanalone support in TOP Makefile,
> could I do that?

i don't know what you mean.  you should be able to do:

--- a/arch/mips/config.mk
+++ b/arch/mips/config.mk
@@ -23,7 +23,8 @@
 
 CROSS_COMPILE ?= mips_4KC-
 
-CONFIG_STANDALONE_LOAD_ADDR ?= 0x80200000 -T mips.lds
+CONFIG_STANDALONE_LOAD_ADDR ?= $(DEFAULT_MIPS_STANDALONE_LOAD_ADDR)
+DEFAULT_MIPS_STANDALONE_LOAD_ADDR = 0x80200000 -T mips.lds
 
 PLATFORM_CPPFLAGS += -DCONFIG_MIPS -D__MIPS__
 

then in your arch/mips/mips64/config.mk, add this one line:
DEFAULT_MIPS_STANDALONE_LOAD_ADDR = 0xFfffFfff80200000 -T mips64.lds

does that not work ?
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20120822/c7f6b597/attachment.pgp>