[U-Boot] [PATCH 1/2 V2] PMIC: MAX77686: Add support for MAX77686

[Rajeshwari Birje]

Hi Joonyoung Shim,

Thank you for comments.
Sorry for late reply.

On Fri, Jun 15, 2012 at 1:20 PM, Joonyoung Shim <dofmind at gmail.com> wrote:
> Hi,
>
> 2012/5/23 Rajeshwari Birje <rajeshwari.birje at gmail.com>:
>> ccing Lukasz Majewski.
>>
>> On Wed, May 23, 2012 at 2:27 PM, Rajeshwari Shinde
>> <rajeshwari.s at samsung.com> wrote:
>>> This patch adds driver and register definitions for PMIC chip
>>> MAX77686.
>>>
>>> Signed-off-by: Rajeshwari Shinde <rajeshwari.s at samsung.com>
>>> ---
>>> changes for V2:
>>>        - using the generic PMIC framework instead of writing separate driver.
>>>  drivers/misc/Makefile        |    1 +
>>>  drivers/misc/pmic_max77686.c |   42 +++++++++++
>>>  include/max77686_pmic.h      |  158 ++++++++++++++++++++++++++++++++++++++++++
>>>  3 files changed, 201 insertions(+), 0 deletions(-)
>>>  create mode 100644 drivers/misc/pmic_max77686.c
>>>  create mode 100644 include/max77686_pmic.h
>>>
>>> diff --git a/drivers/misc/Makefile b/drivers/misc/Makefile
>>> index 271463c..9fac190 100644
>>> --- a/drivers/misc/Makefile
>>> +++ b/drivers/misc/Makefile
>>> @@ -39,6 +39,7 @@ COBJS-$(CONFIG_DIALOG_PMIC) += pmic_dialog.o
>>>  COBJS-$(CONFIG_PMIC_FSL) += pmic_fsl.o
>>>  COBJS-$(CONFIG_PMIC_I2C) += pmic_i2c.o
>>>  COBJS-$(CONFIG_PMIC_SPI) += pmic_spi.o
>>> +COBJS-$(CONFIG_PMIC_MAX77686) += pmic_max77686.o
>>>  COBJS-$(CONFIG_PMIC_MAX8998) += pmic_max8998.o
>>>  COBJS-$(CONFIG_PMIC_MAX8997) += pmic_max8997.o
>>>
>>> diff --git a/drivers/misc/pmic_max77686.c b/drivers/misc/pmic_max77686.c
>>> new file mode 100644
>>> index 0000000..36f7f4d
>>> --- /dev/null
>>> +++ b/drivers/misc/pmic_max77686.c
>>> @@ -0,0 +1,42 @@
>>> +/*
>>> + *  Copyright (C) 2012 Samsung Electronics
>>> + *  Rajeshwari Shinde <rajeshwari.s at samsung.com>
>>> + *
>>> + * See file CREDITS for list of people who contributed to this
>>> + * project.
>>> + *
>>> + * This program is free software; you can redistribute it and/or
>>> + * modify it under the terms of the GNU General Public License as
>>> + * published by the Free Software Foundation; either version 2 of
>>> + * the License, or (at your option) any later version.
>>> + *
>>> + * This program is distributed in the hope that it will be useful,
>>> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
>>> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
>>> + * GNU General Public License for more details.
>>> + *
>>> + * You should have received a copy of the GNU General Public License
>>> + * along with this program; if not, write to the Free Software
>>> + * Foundation, Inc., 59 Temple Place, Suite 330, Boston,
>>> + * MA 02111-1307 USA
>>> + */
>>> +
>>> +#include <common.h>
>>> +#include <pmic.h>
>>> +#include <max77686_pmic.h>
>>> +
>>> +int pmic_init(void)
>>> +{
>>> +       struct pmic *p = get_pmic();
>>> +       static const char name[] = "MAX77686_PMIC";
>>> +
>>> +       puts("Board PMIC init\n");
>>> +       p->name = name;
>>> +       p->interface = PMIC_I2C;
>>> +       p->number_of_regs = PMIC_NUM_OF_REGS;
>>> +       p->hw.i2c.addr = MAX77686_I2C_ADDR;
>>> +       p->hw.i2c.tx_num = 1;
>>> +       p->bus = I2C_PMIC;
>
> If board supports I2C_MULTI_BUS, bus number of pmic can be other value,
> so let's add function parameter for bus number.
This already has parameter for bus number which is p->bus and it does
the following during pmic probe
if (I2C_MULTI_BUS)
                i2c_set_bus_num(bus);

> Thanks.
>
> --
> - Joonyoung Shim

Thanks and Regards,
Rajeshwari Shinde.