[U-Boot] [PATCH v4 2/7] env: unify logic to check and apply changes

Marek Vasut marek.vasut at gmail.com
Fri Aug 24 16:48:55 CEST 2012


Dear Gerlando Falauto,

> The logic of checking special parameters (e.g. baudrate, stdin, stdout,
> for a valid value and/or whether can be overwritten) and applying the
> new value to the running system is now all within a single function
> env_check_apply() which can be called whenever changes are made
> to the environment, no matter if by set, default or import.
> 
> With this patch env_check_apply() is only called by "env set",
> retaining previous behavior.
> 
> Signed-off-by: Gerlando Falauto <gerlando.falauto at keymile.com>
[...]

Reviewed-by: Marek Vasut <marex at denx.de>

but whew, you're giving me a tough time here with such change :-) At least now I 
see how env works ;-)

Best regards,
Marek Vasut


More information about the U-Boot mailing list