[U-Boot] [PATCH v2 17/18] SPL: Enhance drivers/mtd/nand/nand_spl_load.c

Tom Rini trini at ti.com
Fri Aug 24 23:17:28 CEST 2012


On Fri, Aug 24, 2012 at 04:10:44PM -0500, Scott Wood wrote:
> On 08/24/2012 04:09 PM, Scott Wood wrote:
> > On 08/20/2012 11:45 AM, Tom Rini wrote:
> >> diff --git a/drivers/mtd/nand/Makefile b/drivers/mtd/nand/Makefile
> >> index 29dc20e..5475c8c 100644
> >> --- a/drivers/mtd/nand/Makefile
> >> +++ b/drivers/mtd/nand/Makefile
> >> @@ -27,12 +27,7 @@ LIB	:= $(obj)libnand.o
> >>  
> >>  ifdef CONFIG_CMD_NAND
> >>  ifdef CONFIG_SPL_BUILD
> >> -ifdef CONFIG_SPL_NAND_SIMPLE
> >> -COBJS-y += nand_spl_simple.o
> >> -endif
> >> -ifdef CONFIG_SPL_NAND_LOAD
> >> -COBJS-y	+= nand_spl_load.o
> >> -endif
> >> +COBJS-$(CONFIG_SPL_NAND_SIMPLE) += nand_spl_simple.o nand_spl_load.o
> > 
> > OK, I was wrong, I will complain. :-)
> > 
> > The commit message didn't mention you were changing
> > CONFIG_SPL_NAND_SIMPLE.  That needs to be able to support small SPLs.
> > Is your new "enhanced" nand_spl_load small enough (with proper
> > configuration) to work with all the SPLs that currently use
> > nand_spl/nand_boot.c (e.g. PPC 44x)?
> 
> Oh, and please CC me on NAND patches so that I can see them sooner.

Should have put nand in there for patman, sorry.

-- 
Tom


More information about the U-Boot mailing list