[U-Boot] [PATCH v2 04/12] SPL: Add NOR flash booting support

[Tom Rini]

On 08/27/2012 10:29 AM, Daniel Schwierzeck wrote:
> Hi Stefan,
> 
> 2012/8/27 Stefan Roese <sr at denx.de>:
>> SPL NOR flash booting support is quite simple. Only copying of the
>> images is needed.
>>
>> On MPC5xxx we need to make sure to only use the standard memcpy()
>> implementation and not the MPC5xxx specific one. As the MPC5xxx
>> version has some complexity which is not needed for this SPL
>> booting.
>>
>> Signed-off-by: Stefan Roese <sr at denx.de>
[snip]
>> +/*
>> + * Don't use the special MPC5xxx memcpy implementation, only use
>> + * the standard one.
>> + */
>> +#if defined(CONFIG_MPC512X) || defined(CONFIG_MPC5200)
>> +extern void *__memcpy(void *, const void *, size_t);
>> +#define memcpy         __memcpy
>> +#endif
> 
> can't we move this to arch-specifc spl code?
> I think arch/CPU/SoC specific definitions should be avoided in new
> generic frameworks.

This is a good point.  And I think we can further tweak this by
modifying arch/powerpc/lib/Makefile to just not build memcpy_5200.c for
CONFIG_SPL_BUILD.  So lets go with that, and I'll just fixup my local copy.

-- 
Tom