[U-Boot] [PATCH v5 18/25] SPL: NAND: Move arch/arm/cpu/armv7/omap-common/spl_nand.c to common/spl

[Tom Rini]

On 08/27/2012 05:38 PM, Scott Wood wrote:
> On 08/27/2012 07:36 PM, Tom Rini wrote:
>> On 08/27/2012 04:22 PM, Scott Wood wrote:
>>> On 08/27/2012 06:18 PM, Tom Rini wrote:
>>>> diff --git a/common/spl/Makefile b/common/spl/Makefile
>>>> index b61b438..7a77cd3 100644
>>>> --- a/common/spl/Makefile
>>>> +++ b/common/spl/Makefile
>>>> @@ -16,6 +16,7 @@ LIB	= $(obj)libspl.o
>>>>  ifdef CONFIG_SPL_BUILD
>>>>  COBJS-$(CONFIG_SPL_FRAMEWORK) += spl.o
>>>>  COBJS-$(CONFIG_SPL_YMODEM_SUPPORT) += spl_ymodem.o
>>>> +COBJS-$(CONFIG_SPL_NAND_SIMPLE) += spl_nand.o
>>>
>>> Please use a separate config symbol for this.
>>
>> No need, common/spl/libspl.o is dependent on CONFIG_SPL_FRAMEWORK
> 
> Do you not want it to be possible for hardware which cannot use
> CONFIG_SPL_NAND_SIMPLE to use this?

OK, you're right.  I wish we had another NAND driver already :)  Yes,
this should be CONFIG_SPL_NAND_SUPPORT.  The code depends on (and
wouldn't make sense to separate since it would become
CONFIG_SPL_NAND_LOAD, +-) CONFIG_SPL_FRAMEWORK.  But another NAND driver
should provide the required functions.

-- 
Tom