[U-Boot] [PATCH] usb: ehci: don't print debug output

Marek Vasut marex at denx.de
Thu Aug 30 17:47:19 CEST 2012


Dear Lucas Stach,

> This is clearly some sort of debug output and should not
> be printed during normal operation.
> 
> Signed-off-by: Lucas Stach <dev at lynxeye.de>

I think we should apply this ... yet it's been in uboot for so long, so I'd like 
to hear other people opinion :)

> ---
>  drivers/usb/host/ehci-hcd.c | 2 +-
>  1 Datei geändert, 1 Zeile hinzugefügt(+), 1 Zeile entfernt(-)
> 
> diff --git a/drivers/usb/host/ehci-hcd.c b/drivers/usb/host/ehci-hcd.c
> index 2f4fa5e..eb9e323 100644
> --- a/drivers/usb/host/ehci-hcd.c
> +++ b/drivers/usb/host/ehci-hcd.c
> @@ -863,7 +863,7 @@ int usb_lowlevel_init(void)
> 
>  	reg = ehci_readl(&hccr->cr_hcsparams);
>  	descriptor.hub.bNbrPorts = HCS_N_PORTS(reg);
> -	printf("Register %x NbrPorts %d\n", reg, descriptor.hub.bNbrPorts);
> +	debug("Register %x NbrPorts %d\n", reg, descriptor.hub.bNbrPorts);
>  	/* Port Indicators */
>  	if (HCS_INDICATOR(reg))
>  		descriptor.hub.wHubCharacteristics |= 0x80;

Best regards,
Marek Vasut


More information about the U-Boot mailing list