[U-Boot] [PATCH 2/4] usb: ehci: rework to take advantage of new lowlevel interface

[Lucas Stach]

Am Donnerstag, den 30.08.2012, 23:09 +0200 schrieb Marek Vasut:
> Dear Lucas Stach,
> 
> > Kill off ehci-core.h
> > It was used to specify some static controller data. To support more than
> > one controller being active at any time we have to carry the controller
> > data ourselfes. Change the ehci interface accordingly.
> > 
> > NOTE: OMAP implemented the ehci stuff a bit backwards and should be fixed
> > to do the same thing as other platforms. But the change for now is at least
> > compile clean.
> > 
> > Signed-off-by: Lucas Stach <dev at lynxeye.de>
> [...]
> 
> The omap change could be separated out, no?

There is no logic change in OMAP up to now. I just had to add some
forward decls to make it work, which would not be needed if OMAP worked
like all the other platforms.

Actually fixing this would be far more invasive and I don't really want
to do this work, as I don't have a single OMAP board to test with.

> Also, I'd fix all these &(*something)->somethingelse if possible.
> 
I just did it this way to minimize the churn this change is causing.
Removing this, arguably a bit ugly, pointer construct could possibly
introduce logic errors, that are not catchable by just compile testing
this. I would rather leave this to someone who actually cares about the
specific platform.

> Otherwise,
> 
> Reviewed-by: Marek Vasut <marex at denx.de>
> 
Thanks,
Lucas