[U-Boot] [PATCH v2] include/linux/byteorder: Always defines __fswab64, __swab64p and __swab64s

Tom Rini trini at ti.com
Mon Dec 3 14:43:21 CET 2012


On Thu, Nov 15, 2012 at 04:35:26PM +0900, Nobuhiro Iwamatsu wrote:

> When __BYTEORDER_HAS_U64__ is not defined, we got warning following:
> 
> -----
> /tmp/include/linux/byteorder/little_endian.h: In function ???__cpu_to_be64p???:
> /tmp/include/linux/byteorder/little_endian.h:71:2: warning: implicit declaration of function ???__swab64p???
> 		[-Wimplicit-function-declaration]
> -----
> 
> Usually, __arch__swab64* required for __fswab64,  __swab64p and __swab64s
> is defined.  Therefore, __BYTEORDER_HAS_U64__ is unnecessary.
> This removes __BYTEORDER_HAS_U64__.
> 
> Signed-off-by: Nobuhiro Iwamatsu <nobuhiro.iwamatsu.yj at renesas.com>
> CC: Kim Phillips <kim.phillips at freescale.com>
> ---
> v2: Fix mail address.
> 
>  include/linux/byteorder/swab.h |    2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/include/linux/byteorder/swab.h b/include/linux/byteorder/swab.h
> index bb4a046..4334fa7 100644
> --- a/include/linux/byteorder/swab.h
> +++ b/include/linux/byteorder/swab.h
> @@ -122,7 +122,6 @@ static __inline__ void __swab32s(__u32 *addr)
>  	__arch__swab32s(addr);
>  }
>  
> -#ifdef __BYTEORDER_HAS_U64__
>  static __inline__ __attribute__((const)) __u64 __fswab64(__u64 x)
>  {
>  #  ifdef __SWAB_64_THRU_32__
> @@ -141,7 +140,6 @@ static __inline__ void __swab64s(__u64 *addr)
>  {
>  	__arch__swab64s(addr);
>  }
> -#endif /* __BYTEORDER_HAS_U64__ */
>  
>  #if defined(__KERNEL__)
>  #define swab16 __swab16

Applied to u-boot/master, thanks!

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20121203/05d393dc/attachment.pgp>


More information about the U-Boot mailing list