[U-Boot] [PATCH] mtd: nand: mxs: reset BCH earlier, too, to avoid NAND startup problems

Fabio Estevam festevam at gmail.com
Thu Dec 6 00:35:26 CET 2012


Hi Wolfram,

On Wed, Dec 5, 2012 at 6:48 PM, Wolfram Sang <w.sang at pengutronix.de> wrote:

> diff --git a/drivers/mtd/nand/mxs_nand.c b/drivers/mtd/nand/mxs_nand.c
> index 4701be8..e38e151 100644
> --- a/drivers/mtd/nand/mxs_nand.c
> +++ b/drivers/mtd/nand/mxs_nand.c
> @@ -1058,6 +1058,8 @@ int mxs_nand_init(struct mxs_nand_info *info)
>  {
>         struct mxs_gpmi_regs *gpmi_regs =
>                 (struct mxs_gpmi_regs *)MXS_GPMI_BASE;
> +       struct mxs_bch_regs *bch_regs =
> +               (struct mxs_bch_regs *)MXS_BCH_BASE;
>         int i = 0, j;
>
>         info->desc = malloc(sizeof(struct mxs_dma_desc *) *
> @@ -1081,6 +1083,7 @@ int mxs_nand_init(struct mxs_nand_info *info)
>
>         /* Reset the GPMI block. */
>         mxs_reset_block(&gpmi_regs->hw_gpmi_ctrl0_reg);
> +       mxs_reset_block(&bch_regs->hw_bch_ctrl_reg);

In your kernel patch you only do the reset for mx23, but here you do
it for mx28.

Which one is correct?

Regards,

Fabio Estevam


More information about the U-Boot mailing list