[U-Boot] [PATCH 1/4] MMC: DWMMC: Modified fifo size computation
Jaehoon Chung
jh80.chung at samsung.com
Thu Dec 6 04:59:47 CET 2012
It looks good to me.
Added minor comment.
Acked-by: Jaehoon Chung <jh80.chung at samsung.com>
On 12/05/2012 10:31 PM, Amar wrote:
> The current implementation of fifo size computation was giving improper
> values for eMMC channel. Modified the computation as per user manual.
>
> Signed-off-by: Amarendra Reddy <amarendra.xt at samsung.com>
> ---
> drivers/mmc/dw_mmc.c | 2 ++
> 1 files changed, 2 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/mmc/dw_mmc.c b/drivers/mmc/dw_mmc.c
> index 4070d4e..62dc152 100644
> --- a/drivers/mmc/dw_mmc.c
> +++ b/drivers/mmc/dw_mmc.c
> @@ -332,6 +332,8 @@ static int dwmci_init(struct mmc *mmc)
> dwmci_writel(host, DWMCI_BMOD, 1);
>
> fifo_size = dwmci_readl(host, DWMCI_FIFOTH);
> + fifo_size = ((fifo_size & RX_WMARK(0xFFF)) >> 16) + 1;
How about using like FIFO_SIZE_MASK?
> +
> if (host->fifoth_val)
> fifoth_val = host->fifoth_val;
> else
>
More information about the U-Boot
mailing list