[U-Boot] [PATCH 1/3 V2] EHCI: Exynos: Add fdt support
Marek Vasut
marex at denx.de
Thu Dec 6 19:02:31 CET 2012
Dear Simon Glass,
[...]
> > [...]
> >
> > error output should be really puts() or printf() ...
>
> Ick that bloats the code badly for an uncommon case. Would really
> prefer to avoid this.
What do you mean? Are you saying this debug() is correct and this is triggered
often? How come?
> > You can also use errno.h instead of -1.
>
> True, it might help debugging, although many times it is hard to map
> the error onto a suitable number designed for Linux. This 'return -1'
> is pretty common in U-Boot (generic error).
I know, but it'd be nice if this changed. Just a suggestion.
Best regards,
Marek Vasut
More information about the U-Boot
mailing list